Adapt searchable snapshots code to latest master changes#52258
Merged
tlrx merged 2 commits intoelastic:feature/searchable-snapshotsfrom Feb 12, 2020
Merged
Adapt searchable snapshots code to latest master changes#52258tlrx merged 2 commits intoelastic:feature/searchable-snapshotsfrom
tlrx merged 2 commits intoelastic:feature/searchable-snapshotsfrom
Conversation
tlrx
added
>non-issue
:Distributed/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
DaveCTurner
approved these changes
Feb 12, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM; one suggestion about an exception message.
...able-snapshots/src/main/java/org/elasticsearch/index/store/SearchableSnapshotIndexInput.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks David! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adapts searchable snapshots to the latest changes from
master.The REST handlers declare their routes differently since #51950 and
SearchableSnapshotIndexInputneed to account for segment infos files that are stored in shard snapshot metadata hash and not uploaded to the blob store anymore since #51729.